1
0
forked from drath/libratbag

Drop the Led.Type property

The led type was the physical led type to describe where the LED sits.

This property is basically unused and of questionable use anyway. GUI
applications would need to rely on drawings of the mouse anyway. Scripts don't
really care because ratbagctl uses the led index anyway. The only time this
matters is when we're looking at (human) device discovery. But even then just
trying to set the LED is enough to figure out which one is which.

So let's drop this API on the assumption that it's not really needed and
maintaining and extending that enum forever is not necessary.

This is not a full purge, merely the DBus API that gets dropped.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer
2019-02-22 15:06:39 +10:00
committed by Benjamin Tissoires
parent 79711dfdad
commit 367aa29dfe
8 changed files with 28 additions and 85 deletions

View File

@@ -284,10 +284,15 @@ enum ratbag_led_mode {
*/
RATBAG_LED_BREATHING,
};
/**
* @ingroup enums
*
* LED types, usually based on their physical location
*
* This enum is deprecated and should not be used.
*
* @deprecated
*/
enum ratbag_led_type {
RATBAG_LED_TYPE_LOGO = 1,

View File

@@ -1470,12 +1470,6 @@ ratbag_led_get_mode(struct ratbag_led *led)
return led->mode;
}
LIBRATBAG_EXPORT enum ratbag_led_type
ratbag_led_get_type(struct ratbag_led *led)
{
return led->type;
}
LIBRATBAG_EXPORT bool
ratbag_led_has_mode(struct ratbag_led *led,
enum ratbag_led_mode mode)

View File

@@ -1157,18 +1157,6 @@ ratbag_button_get_special(struct ratbag_button *button);
*/
struct ratbag_led *
ratbag_profile_get_led(struct ratbag_profile *profile, unsigned int index);
/**
* @ingroup led
*
* This function returns the type for ratbag_led.
*
* @param led A previously initialized ratbag LED
* @return The LED type @ref ratbag_led_type
*
* @see ratbag_led_set_mode
*/
enum ratbag_led_type
ratbag_led_get_type(struct ratbag_led *led);
/**
* @ingroup led