From 4240e067a91d168dc85fce74ef53f641a13b2f81 Mon Sep 17 00:00:00 2001 From: Yaroslav Chvanov Date: Sat, 20 May 2023 10:57:00 +0300 Subject: [PATCH] openinput: return early instead of making an error-prone zero-sized VLA Fixes a clang-analyze warning. --- src/driver-openinput.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/driver-openinput.c b/src/driver-openinput.c index ad002866..1e330db1 100644 --- a/src/driver-openinput.c +++ b/src/driver-openinput.c @@ -386,6 +386,11 @@ openinput_read_supported_function_pages(struct ratbag_device *device) return ret; total = count + left; + if (total == 0) { + log_debug(ratbag, + "openinput: not proceeding to read device functions as there are 0 pages\n"); + return 0; + } uint8_t pages[total]; memcpy(pages, buffer, count);