From 5637755345f316ae1551fd9b082bada503c24e69 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Mon, 24 Jul 2017 10:31:50 +1000 Subject: [PATCH] Only reset the driver to NULL on unusual exits If a driver succeeded but then fails sanity checks, leave the driver set and let the cleanup code handle the rest. Otherwise, memory allocated by the driver's probe() function is never released. Fixes a valgrind memory leak complaint when running tests for invalid devices (e.g. device_profiles_num_0). Signed-off-by: Peter Hutterer --- src/libratbag.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libratbag.c b/src/libratbag.c index 3711cbfb..6ecbc5c5 100644 --- a/src/libratbag.c +++ b/src/libratbag.c @@ -328,9 +328,8 @@ ratbag_test_driver(struct ratbag_device *device, log_error(ratbag, "%s: error opening hidraw node (%s)\n", device->name, strerror(-rc)); -error: device->driver = NULL; - +error: return false; }