From 635257d6b80ac58bbf2c20d85b3113799973f00c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Filipe=20La=C3=ADns?= Date: Tue, 9 Jul 2019 14:54:38 +0100 Subject: [PATCH] hidpp20: improve debug messages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Filipe Laíns --- src/hidpp20.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/hidpp20.c b/src/hidpp20.c index 254411c9..35752bc8 100644 --- a/src/hidpp20.c +++ b/src/hidpp20.c @@ -1542,6 +1542,8 @@ hidpp20_onboard_profiles_read_sector(struct hidpp20_device *device, .msg.address = CMD_ONBOARD_PROFILES_MEMORY_READ, }; + hidpp_log_debug(device, "Reading sector 0x%04x\n", sector); + feature_index = hidpp_root_get_feature_idx(device, HIDPP_PAGE_ONBOARD_PROFILES); if (feature_index == 0) @@ -1589,6 +1591,9 @@ hidpp20_onboard_profiles_is_sector_valid(struct hidpp20_device *device, crc = hidpp_crc_ccitt(data, sector_size - 2); read_crc = hidpp_get_unaligned_be_u16(&data[sector_size - 2]); + if (crc != read_crc) + hidpp_log_debug(device, "Invalid CRC (%04x != %04x)\n", read_crc, crc); + return crc == read_crc; }