From a17613459be3eb101a2c9ba5d4b0ac84eea89e26 Mon Sep 17 00:00:00 2001
From: Peter Hutterer <peter.hutterer@who-t.net>
Date: Mon, 18 Feb 2019 10:23:46 +1000
Subject: [PATCH] circleci: drop scan-build from the jobs to run

Scan-build is at the point where it gives us too many false positives to be
reliable and they're not easily fixable other than sprinkling
"ignore_clang_sa_mem_leak" comments all over the source.

This caused us to drop F29 from the CI earlier, see 1225f421c0a50083, but
really we just shouldn't use something that's so unreliable as part of our CI.

The main issue continues to be the use of __attribute__((cleanup)) but others
give us false positives too.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
---
 circle.yml | 29 -----------------------------
 1 file changed, 29 deletions(-)

diff --git a/circle.yml b/circle.yml
index fb645b79..a577f031 100644
--- a/circle.yml
+++ b/circle.yml
@@ -55,12 +55,6 @@ libratbag_references:
   export_logs: &export_logs
     store_artifacts:
       path: ~/libratbag/build/meson-logs
-  ninja_scan_build: &ninja_scan_build
-    run:
-      <<: *build_default
-      name: Ninja scan-build
-      environment:
-        NINJA_ARGS: scan-build
   start_dbus: &start_dbus
     run:
       name: Start dbus daemon
@@ -125,22 +119,6 @@ ubuntu_settings: &ubuntu_settings
     - *check_uninstall
     - *export_logs
 
-
-scan_build_run: &scan_build_run
-  <<: *default_settings
-  steps:
-    - *fedora_fetch_cache
-    - *fedora_install
-    - run:
-        name: Install clang and find
-        command: dnf install -y clang-analyzer findutils python3-beautifulsoup4
-    - checkout
-    - *ninja_scan_build
-    - *export_logs
-    - run:
-        name: Check scan-build results
-        command: python3 ~/libratbag/tools/check_scan_build.py ~/libratbag/build/meson-logs/scanbuild
-
 doc_build: &doc_build
   <<: *default_settings
   steps:
@@ -219,10 +197,6 @@ jobs:
     <<: *doc_build
     docker:
       - image: fedora:28
-  scan_build:
-    <<: *scan_build_run
-    docker:
-      - image: fedora:28
   doc_deploy:
     <<: *docs_deploy
     docker:
@@ -235,9 +209,6 @@ workflows:
     jobs:
       # - fedora_rawhide
       - fedora_cache
-      - scan_build:
-          requires:
-            - fedora_cache
       - ubuntu_17_10
       - fedora_latest:
           requires: