From f72c96914b09f408bc6266cb49e6b58698bb13e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Vuchener?= Date: Tue, 30 Aug 2016 16:50:18 +0200 Subject: [PATCH] hidpp20: fix reading has_dpi_shift MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comparison was always false because of missing bit shift. Signed-off-by: Clément Vuchener --- src/hidpp20.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hidpp20.c b/src/hidpp20.c index 2b707a2b..9c493d75 100644 --- a/src/hidpp20.c +++ b/src/hidpp20.c @@ -1286,7 +1286,7 @@ hidpp20_onboard_profiles_initialize(struct hidpp20_device *device, profiles->num_buttons = msg.msg.parameters[5] <= 16 ? msg.msg.parameters[5] : 16; profiles->num_modes = HIDPP20_DPI_COUNT; profiles->has_g_shift = (info->mechanical_layout & 0x03) == 2; - profiles->has_dpi_shift = (info->mechanical_layout & 0x0c) == 2; + profiles->has_dpi_shift = ((info->mechanical_layout & 0x0c) >> 2) == 2; switch(info->various_info & 0x07) { case 1: profiles->corded = 1;