From 15dd6b4f2b511d074a7cfd721d9b478ee86d4056 Mon Sep 17 00:00:00 2001 From: Benjamin Tissoires Date: Tue, 23 May 2017 14:22:50 +0200 Subject: [PATCH] hidpp20: color effects, fix endianness We are receiving big endian, thus the weird power of two locations. Signed-off-by: Benjamin Tissoires --- src/hidpp-generic.c | 4 ++-- src/hidpp20.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/hidpp-generic.c b/src/hidpp-generic.c index 889ca708..fdeaa6bc 100644 --- a/src/hidpp-generic.c +++ b/src/hidpp-generic.c @@ -149,8 +149,8 @@ struct hidpp20_8070_location_mapping { static const struct hidpp20_8070_location_mapping hidpp20_8070_location_mapping[] = { LED_LOC_MAPPING(0, "None", RATBAG_LED_TYPE_UNKNOWN), - LED_LOC_MAPPING(256, "Logo LED", RATBAG_LED_TYPE_LOGO), - LED_LOC_MAPPING(512, "Side LED", RATBAG_LED_TYPE_SIDE), + LED_LOC_MAPPING(1, "Logo LED", RATBAG_LED_TYPE_LOGO), + LED_LOC_MAPPING(2, "Side LED", RATBAG_LED_TYPE_SIDE), }; const struct ratbag_button_action * diff --git a/src/hidpp20.c b/src/hidpp20.c index d0707a94..c3ff14b2 100644 --- a/src/hidpp20.c +++ b/src/hidpp20.c @@ -555,7 +555,7 @@ hidpp20_color_led_effects_get_zone_info(struct hidpp20_device *device, return rc; msg_info = (struct hidpp20_color_led_zone_info *)msg.msg.parameters; - info->location = msg_info->location; + info->location = hidpp_be_u16_to_cpu(msg_info->location); info->num_effects = msg_info->num_effects; info->persistency_caps = msg_info->persistency_caps;