From 2a35bf009fb3099d1bf55833c6c06dd6c706c7de Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 4 Apr 2017 10:42:02 +1000 Subject: [PATCH] configure.ac: drop "auto" detection of test dependencies Always build the tests, if someone doesn't want it disable it with a configure flag but at least be explicit about it. Justification: any developer should build the full stack as intended by default. Distributions may disable bits and pieces, but they shouldn't rely on auto-detection to figure it out, they should explicity disable those bits they don't want. Signed-off-by: Peter Hutterer --- configure.ac | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 49ec4148..4176d324 100644 --- a/configure.ac +++ b/configure.ac @@ -107,20 +107,12 @@ if test "x$build_documentation" = "xyes"; then fi AC_ARG_ENABLE(tests, - AS_HELP_STRING([--enable-tests], [Build the tests (default=auto)]), + AS_HELP_STRING([--enable-tests], [Build the tests (default=yes)]), [build_tests="$enableval"], - [build_tests="auto"]) + [build_tests="yes"]) -PKG_CHECK_MODULES(CHECK, [check >= 0.9.10], [HAVE_CHECK="yes"], [HAVE_CHECK="no"]) - -if test "x$build_tests" = "xauto"; then - build_tests="$HAVE_CHECK" -fi if test "x$build_tests" = "xyes"; then - if test "x$HAVE_CHECK" = "xno"; then - AC_MSG_ERROR([Cannot build tests, check is missing]) - fi - + PKG_CHECK_MODULES(CHECK, [check >= 0.9.10]) AC_PATH_PROG(VALGRIND, [valgrind]) fi