From 770dd62b1d95f99215f0c88f5253be308b10c4c0 Mon Sep 17 00:00:00 2001 From: "Thomas H. P. Andersen" Date: Mon, 19 Mar 2018 01:13:10 +0100 Subject: [PATCH] hidpp10: fix finding the closest dpi (#463) value and dpi are unsigned so the delta calculations was wrong when dpi is larger than than value. Casting to int should be fine for the expected range of values in those variables. --- src/hidpp10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hidpp10.c b/src/hidpp10.c index cd334213..e0485fd7 100644 --- a/src/hidpp10.c +++ b/src/hidpp10.c @@ -643,7 +643,7 @@ hidpp10_get_dpi_mapping(struct hidpp10_device *dev, unsigned int value) min_delta = INT_MAX; for (i = 0; i < dev->dpi_count; i++) { - delta = abs(value - m[i].dpi); + delta = abs((int)value - (int)m[i].dpi); if (delta < min_delta) { result = m[i].raw_value; min_delta = delta;