Drop the Button.Type property

The button type was the physical button type, not the logically assigned
button number.

This property is basically unused and of questionable use anyway. GUI
applications would need to rely on drawings of the mouse anyway. Scripts don't
really care because ratbagctl uses the button index anyway. The only time this
matters is when we're looking at (human) device discovery. But often clicking
around is enough to figure out the index.

So let's drop this API on the assumption that it's not really needed and
maintaining and extending that enum forever is not necessary.

This is not a full purge, merely the DBus API that gets dropped.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer
2019-02-22 14:56:31 +10:00
committed by Benjamin Tissoires
parent 32a5ad377e
commit 79711dfdad
9 changed files with 19 additions and 131 deletions

View File

@@ -142,6 +142,10 @@ enum ratbag_resolution_capability {
* @ingroup enums
*
* Button types describing the physical button.
*
* This enum is deprecated and should not be used.
*
* @deprecated
*/
enum ratbag_button_type {
RATBAG_BUTTON_TYPE_UNKNOWN = 0,

View File

@@ -1240,12 +1240,6 @@ ratbag_profile_get_button(struct ratbag_profile *profile,
return NULL;
}
LIBRATBAG_EXPORT enum ratbag_button_type
ratbag_button_get_type(struct ratbag_button *button)
{
return button->type;
}
LIBRATBAG_EXPORT enum ratbag_button_action_type
ratbag_button_get_action_type(struct ratbag_button *button)
{

View File

@@ -1056,25 +1056,6 @@ ratbag_button_set_user_data(struct ratbag_button *button, void *userdata);
void*
ratbag_button_get_user_data(const struct ratbag_button *button);
/**
* @ingroup button
*
* Return the type of the physical button. This function is intended to be
* used by configuration tools to provide a generic list of button names or
* handles to configure devices. The type describes the physical location of
* the button and remains constant for the lifetime of the device.
* For example, a button of type @ref RATBAG_BUTTON_TYPE_WHEEL_CLICK may be
* mapped to a logical middle button, but the physical description is that
* of a wheel click.
*
* For the button currently mapped to this physical button, see
* ratbag_button_get_button()
*
* @return The type of the button
*/
enum ratbag_button_type
ratbag_button_get_type(struct ratbag_button *button);
/**
* @ingroup button
*