From d82ee06bfde596a6f6aaa32be4d401aaaad87f05 Mon Sep 17 00:00:00 2001 From: Benjamin Tissoires Date: Wed, 26 Aug 2015 16:59:39 -0400 Subject: [PATCH] Call only once per button per profile .read_button ratbag_profile_init_buttons() already loops over the given number of buttons. Remove the extra for loop and save some CPU (and possibly USB depending on the driver) cycles. Signed-off-by: Benjamin Tissoires --- src/libratbag.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libratbag.c b/src/libratbag.c index 05a4bceb..42aec6db 100644 --- a/src/libratbag.c +++ b/src/libratbag.c @@ -570,8 +570,7 @@ ratbag_create_profile(struct ratbag_device *device, assert(device->driver->read_profile); device->driver->read_profile(profile, index); - for (i = 0; i < num_buttons; i++) - ratbag_profile_init_buttons(profile, i); + ratbag_profile_init_buttons(profile, num_buttons); return profile; }