From e268100d31bcc7c9ba8a96579547b73039b602ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Filipe=20La=C3=ADns?= Date: Mon, 31 Aug 2020 13:57:04 +0100 Subject: [PATCH] libratbag-data: log message if the device is a Logitech receiver MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We have been receiving countless issues and PRs reporting or "fixing" the device IDs because they think it's wrong. Hopefully this will give them an hint that is intended behavior. If they look closely at the log, on a recent enough kernel, they should see their device show up with the internal ID. Signed-off-by: Filipe Laíns --- src/libratbag-data.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/libratbag-data.c b/src/libratbag-data.c index 9f137b11..1016e649 100644 --- a/src/libratbag-data.c +++ b/src/libratbag-data.c @@ -34,6 +34,7 @@ #include "libratbag-private.h" #include "libratbag-data.h" #include "hidpp20.h" +#include "usb-ids.h" #define GROUP_DEVICE "Device" @@ -517,7 +518,9 @@ ratbag_device_data_new_for_id(struct ratbag *ratbag, const struct input_id *id) goto out; } - if (!data) + if (id->vendor == USB_VENDOR_ID_LOGITECH && (id->product & 0xff00) == 0xc500) + log_debug(ratbag, "%04x:%04x is a Logitech receiver, not a device. Ignoring...\n", id->vendor, id->product); + else if (!data) log_debug(ratbag, "No data file found for %04x:%04x\n", id->vendor, id->product); out: