drath/libratbag
1
0
Fork 1
mirror of https://github.com/libratbag/libratbag.git synced 2026-11-07 23:23:52 +01:00
Code Issues Projects Releases Wiki Activity
2,352 Commits 4 Branches 24 Tags
2bf349459b05f675e1ef73600255429f42e93064
Commit Graph

476 Commits

Author SHA1 Message Date
Yaroslav Chvanov
2bf349459b tools: ignore a false positive warning 2023-03-01 22:17:32 +03:00
Yaroslav Chvanov
57ac72077f tools: don't use complex types as default function arguments 2023-03-01 22:17:32 +03:00
Yaroslav Chvanov
a192088f13 tools: chain exceptions within exceptions 2023-03-01 22:17:32 +03:00
Yaroslav Chvanov
fa67024110 tools: fix ambiguous variable names 
These one-letter variable names really are bad.
A good illustration of this is resolutions being assigned to the
variable where Ratbagd was, both of such variables were always names
just "r".
 2023-03-01 22:17:32 +03:00
Yaroslav Chvanov
a66e6d2066 Automatically fix Ruff warnings 2023-03-01 22:17:31 +03:00
Yaroslav Chvanov
3aa82d2b35 build: add Ruff for Python code linting 2023-03-01 22:17:31 +03:00
Yaroslav Chvanov
49146638a6 Format Python code 2023-03-01 22:17:31 +03:00
Yaroslav Chvanov
c723490fc3 build: add Python code formatting with black 
NOTE: this will fail tests as of this commit, as the code is not
formatted yet.

We didn't explicitly specify a minimum Python version before that, so I
used v3.7 here, because it's the minimal version Ruff - a Python linter
I will add in the next commit - supports.
 2023-03-01 22:17:31 +03:00
Yaroslav Chvanov
bc9fa92667 tools: prevent a syntax error for code editors and linters 2023-03-01 22:17:31 +03:00
Yaroslav Chvanov
41b55a1aff Rename Python files throughout the project to have .py* in the suffix 
This just makes it more clear what these files are without opening them.
 2023-03-01 22:17:31 +03:00
Yaroslav Chvanov
f9266496b0 ratbagctl: check if there is an active resolution 2023-03-01 03:59:58 +03:00
Yaroslav Chvanov
26cc2c7138 ratbagctl: check if there is an active profile 2023-03-01 03:59:19 +03:00
Yaroslav Chvanov
11f1ba9f37 tools: don't try to return the first resolution on error 2023-03-01 03:58:58 +03:00
Yaroslav Chvanov
fc80221187 tools: don't try to return the first profile on error 
This may make an exception.
 2023-03-01 03:57:54 +03:00
Yaroslav Chvanov
84626322c7 tools: remove helpers for deprecated LED types 2023-02-25 13:30:06 +03:00
Yaroslav Chvanov
85cab665b5 tools: remove helpers for the deprecated ratbag_button_type 2023-02-25 13:03:37 +03:00
Yaroslav Chvanov
9ec13c2862 tools: write to file directly without using print 2023-02-25 01:03:13 +03:00
Yaroslav Chvanov
3be9f38d2c tools: remove unused variables 2023-02-25 00:57:18 +03:00
Yaroslav Chvanov
e49c18b909 tools: use with-statements to open files 
I'll be honest, writing to files with `print` looks weird...
 2023-02-25 00:55:53 +03:00
Yaroslav Chvanov
0db55eda25 tools: remove unused arguments 2023-02-25 00:22:07 +03:00
Yaroslav Chvanov
313c34fa98 tools: fix incorrect special method signature 
Continuation of 62678baca1.
 2023-02-25 00:22:07 +03:00
Yaroslav Chvanov
b275204c87 tools: check snprintf size argument to prevent potential overflow 2023-02-25 00:22:07 +03:00
Yaroslav Chvanov
1eed280b82 tools: remove an unused function that always raises 
..unless it's used by some third-party library? Either way, it just
raises an error.
 2023-02-24 23:43:33 +03:00
Yaroslav Chvanov
dcdd7be8d8 tools: remove an unnecessary variable definition 2023-02-24 22:46:34 +03:00
Yaroslav Chvanov
62678baca1 tools: fix incorrect special method signature 
They worked fine nonetheless as we only called these manually.
 2023-02-24 22:43:37 +03:00
Yaroslav Chvanov
4b2b5a2038 ratbagctl: capitalize device type instead of having it in upper case 2023-02-14 16:29:21 +03:00
Julian Kandlhofer
4f36371af3 implement 'DeviceType' property 
Signed-off-by: Julian Kandlhofer <julian.kandlhofer@gmail.com>
 2023-02-14 16:29:20 +03:00
Yaroslav Chvanov
440292fda1 device: add firmware version API 2023-01-03 04:21:07 +03:00
Yaroslav Chvanov
7a5b9b4367 Fix typos throughout the codebase 2023-01-03 04:17:44 +03:00
Yaroslav Chvanov
f595c96495 ratbagctl: fix typo 2022-12-26 23:44:48 +03:00
Stephan Lachnit
45118b8fa5 Implement disabled resolutions 
Implements feature to disable resolutions from a static resolution list.
Updates DBus API and tests accordingly.

Signed-off-by: Stephan Lachnit <stephanlachnit@protonmail.com>
 2022-12-25 22:54:16 +03:00
Stephan Lachnit
c99fd654e3 Make order of resolution properties consistent 
Resolution properties should be in the order (active, default).

Signed-off-by: Stephan Lachnit <stephanlachnit@protonmail.com>
 2022-12-25 22:54:16 +03:00
Peter Hutterer
f6bfed4da0 ratbagd: switch Profile.Enabled to Profile.Disabled 
When a boolean property is optional, the default None value and the False
value both represent a boolean false. So let's rename the property so that the
boolean values cannot be confused, because None and (Disabled == false) have
the same meaning (profile is enabled).

This is an API break.

Fixes #756

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
 2022-12-25 22:54:16 +03:00
Yaroslav Chvanov
e32145ecc7 ratbagd.py: fix changes to IsActive potentially not being notified about 2022-12-23 23:41:30 +03:00
Yaroslav Chvanov
2031e169ab ratbagd.py: make the profile dirty after changing report rate 
This fixes the "Apply" button being disabled after changing report rate
in Piper (once this file gets synchronized there).
 2022-12-23 23:40:55 +03:00
Yaroslav Chvanov
6e406d5127 ratbagc: add NONE as allowed action type 
Fixes button disabling not working with ratbag-command.
 2022-12-23 04:27:43 +03:00
Yaroslav Chvanov
d6c5f18362 Revert "tools: convert our enum equivalents to python enums" 
This reverts commit 95243307ce.

I don't see any reason it has been there at all, and it also breaks
ratbag-command because of probably mistakenly removed Macro.NONE.
 2022-12-23 04:26:40 +03:00
Yaroslav Chvanov
56e0ee9279 ratbagctl: check if disabling buttons is supported 2022-12-23 04:01:29 +03:00
Peter Hutterer
39b8f2bce2 ratbagd: map disabling a button to the existing action type None 
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
 2022-12-23 03:38:18 +03:00
Peter Hutterer
95243307ce tools: convert our enum equivalents to python enums 
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
 2022-12-23 03:34:31 +03:00
Yaroslav Chvanov
0b8f4a25b1 tools: put the list of possible button action types into a const 2022-12-22 00:52:05 +03:00
Yaroslav Chvanov
3b0ac12cc7 ratbagctl: add an error message if the key supplied to macro is wrong 2022-12-22 00:52:05 +03:00
Kyoken
39b6178d92 fix typo in macro bindings 2022-12-22 00:52:05 +03:00
Kyoken
49b9ad5647 use key name instead of code for binding 2022-12-22 00:52:05 +03:00
Kyoken
434b0537b5 fix ratbag-command key bindings 2022-12-22 00:52:05 +03:00
Kyoken
2eeacc354f implement key bindings feature 2022-12-22 00:51:59 +03:00
listout
05c5815fb9 Use fprintf instead of error 
hidpp files were using the error function from error.h header file.
Unfortunately not every libc comes with this particular header file, so
with this patch we won't be requiring to be rely on error function and
use fprintf function.

Thanks to developer Yaroslav Chvanov <staticssleever668> for the
original suggestion

Closes: https://github.com/libratbag/libratbag/issues/1253

Signed-off-by: listout <listout@protonmail.com>
 2022-07-29 14:22:05 +00:00
Kyoken
e0dc0a3a5b fix ratbag-command led setting 2022-01-24 12:55:12 +10:00
Stephen Kitt
206bc5996d man: add both variants in ratbagctl.1 synopsis 
PR #1188
 2021-06-30 19:23:30 +01:00
Stephan Lachnit
f822fb0fa7 remove unused string format to fix flake8 (#1024) 
Signed-off-by: Stephan Lachnit <stephanlachnit@protonmail.com>
 2020-07-06 11:48:47 +02:00