From 2908d038c237310e43f00735a074ce29fb414396 Mon Sep 17 00:00:00 2001 From: DrathVader Date: Fri, 27 Feb 2026 23:14:14 +0100 Subject: [PATCH 1/5] we mostly capitalize --- src/gpu.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gpu.cpp b/src/gpu.cpp index d04e4db..8d65f84 100644 --- a/src/gpu.cpp +++ b/src/gpu.cpp @@ -24,7 +24,7 @@ int detect(gpuSensors* target, const std::string& pci) { applog(LOG::INF, "Detected path \"{}\"", target->hwmon); if (utils::fileExists(target->hwmon + rel_metrics_path)) { - applog(LOG::INF, "found gpu_metrics"); + applog(LOG::INF, "Found gpu_metrics"); target->hasGpuMetrics = true; } return 0; From e5b9403390efdf0336a070146d293a6121770215 Mon Sep 17 00:00:00 2001 From: DrathVader Date: Fri, 27 Feb 2026 23:15:55 +0100 Subject: [PATCH 2/5] clearer readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a0acd3f..069e592 100644 --- a/README.md +++ b/README.md @@ -61,7 +61,7 @@ Text04="$dll(hwinfo,1,Vcore,3)V $Right($dll(hwinfo,1,Average Effective Clock,a)M ### Additional notes -- To read motherboard sensors on ASUS ROG STRIX B550-A GAMING, as of Linux 6.16 you need to booth with kernel parameter of `acpi_enforce_resources=lax`. On Fedora it can be added by appending it to `/etc/kernel/cmdline`. +- To read motherboard sensors on ASUS ROG STRIX B550-A GAMING, as of Linux 6.16 you need to booth with kernel parameter of `acpi_enforce_resources=lax`, and load the `nct6775` module. On Fedora it can be added by appending it to `/etc/kernel/cmdline`. On Silverblue/Kinoite use `rpm-ostree kargs --append=...` - You need to be able to read RAPL as user. Create in `/etc/tmpfiles.d/intelrapl.conf` with content `z- /sys/class/powercap/intel-rapl:0/energy_uj 0440 root uucp - -`. Adjust uucp to whatever group applicable, like `dialout`. - `compile_commands.json` is so clang understands this project, so we can edit it with helix/neovim. Generated with `bear -- make`, make sure to run `make clean` beforehand. From 8b8bf695c9cb7ebc0f0d7426b4c3f23bfac78a4d Mon Sep 17 00:00:00 2001 From: DrathVader Date: Fri, 27 Feb 2026 23:16:19 +0100 Subject: [PATCH 3/5] oops missed a line --- src/hass.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/hass.cpp b/src/hass.cpp index 68da34b..e8f20ef 100644 --- a/src/hass.cpp +++ b/src/hass.cpp @@ -1,3 +1,4 @@ +#ifdef ENABLE_HOME_ASSISTANT #include #include @@ -6,8 +7,6 @@ #include #include -#ifdef ENABLE_HOME_ASSISTANT - HomeAssistant::HomeAssistant(const Config& config) { m_config = config; } @@ -161,4 +160,4 @@ void HomeAssistant::disconnect() const { lws_context_destroy(context); } -#endif \ No newline at end of file +#endif From b3a2e8409776995dbb18522c88409725674db669 Mon Sep 17 00:00:00 2001 From: DrathVader Date: Fri, 27 Feb 2026 23:16:49 +0100 Subject: [PATCH 4/5] clearer log message --- src/sys.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/sys.cpp b/src/sys.cpp index 8fe883d..af51137 100644 --- a/src/sys.cpp +++ b/src/sys.cpp @@ -70,9 +70,10 @@ int sys::detect(sysSensors* s, const std::string& platform) { try { s->hwmon = utils::getFirstDir("/sys/devices/platform/" + platform + "/hwmon"); } catch (...) { - applog(LOG::ERR, "Can't open sys hwmon. Module loaded? Kernel params added?"); + applog(LOG::ERR, "Can't open \"/sys/devices/platform/{}/hwmon\". Kernel params added? Module loaded?", platform); return -1; } + applog(LOG::INF, "Found system sensors"); return 0; } From 317a73dac361a0700f797c6a6edcdf4a2fae939e Mon Sep 17 00:00:00 2001 From: DrathVader Date: Fri, 27 Feb 2026 23:17:36 +0100 Subject: [PATCH 5/5] dont crash if sensors fail to detect --- src/app.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/app.cpp b/src/app.cpp index 9c25cda..29db7f7 100644 --- a/src/app.cpp +++ b/src/app.cpp @@ -102,11 +102,8 @@ void Application::sensorsThread(const std::stop_token& st) { ret += gpu::detect(&m_sensors.gpu, m_config.gpu_pciaddr); ret += sys::detect(&m_sensors.sys, m_config.sys_sensor); m_sensors.home.mountpoint = m_config.home_dir; - if (ret < 0) { + if (ret < 0) applog(LOG::ERR, "Failed to detect some sensors"); - this->Crash(ret); - return; - } while (!st.stop_requested()) { auto start = std::chrono::steady_clock::now(); @@ -209,4 +206,4 @@ void Application::displayThread(const std::stop_token& st) { // goodbye msg lcd.writeBuf(2, 0, utils::center("Goodbye", 40)); lcd.flushBuf(); -} \ No newline at end of file +}