1
0
forked from drath/libratbag

Move note on return values to the interface documentation

This commit is contained in:
Jente Hidskes
2017-09-07 12:00:50 +02:00
committed by Peter Hutterer
parent 8e9bf7b48a
commit 2473f66cb3
2 changed files with 5 additions and 6 deletions

View File

@@ -18,6 +18,11 @@ object. Properties marked as 'mutable' may change, and a
`org.freedesktop.DBus.Properties.PropertyChanged` signal is sent for those
unless otherwise specified.
All setters (whether implicit for read-write properties or explicit) return
success instead of the internal return value because DBus does not like
non-standard error values. This means that clients should check for capabilities
beforehand and that the `Commit()` method (see below) signals an error.
org.freedesktop.ratbag1.Manager
===============================

View File

@@ -373,12 +373,6 @@ ratbagd_profile_set_name(sd_bus *bus,
NULL);
}
/*
* Note: we should return `r`, but the d-bus bindings doesn't
* like non standard errors. So just return success and let the client
* check for the capability before-hand and let .commit() signal an
* error.
*/
return 0;
}