DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

data: check for missing buttons

Browse Source 
The Logitech G502 had a wrong button ID so it doesn't show up. We have a
correctly named leader and path though so let's add that to the checks.

https://github.com/libratbag/piper/issues/240

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer
2018-11-27 15:12:06 +10:00
committed by Benjamin Tissoires
parent b489ac871d
commit 2dca516afa
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
data/gnome/check-svg.py
View File

@@ -66,13 +66,14 @@ def check_elements(root, prefix, required=0):
highest = -1
for idx in range(0, 20):
e = '{}{}'.format(prefix, idx)
previous = '{}{}'.format(prefix, idx - 1)
leader = '{}{}-leader'.format(prefix, idx)
path = '{}{}-path'.format(prefix, idx)
if e in element_ids:
highest = idx
previous = '{}{}'.format(prefix, idx - 1)
if idx > 0 and previous not in element_ids:
logger.warning("Non-consecutive {}: {}".format(prefix, e))
leader = '{}{}-leader'.format(prefix, idx)
if leader not in element_ids:
logger.error("Missing {} for {}".format(leader, e))
else:
@@ -80,9 +81,12 @@ def check_elements(root, prefix, required=0):
if element is None or len(element) != 1 or element[0] is None:
logger.error("Missing style property for {}".format(leader))
path = '{}{}-path'.format(prefix, idx)
if path not in element_ids:
logger.error("Missing {} for {}".format(path, e))
elif leader in element_ids:
logger.error("Have {} but not {}".format(leader, e))
elif path in element_ids:
logger.error("Have {} but not {}".format(path, e))
elif idx < required:
logger.error("Missing {}: {}".format(prefix, e))