DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

hidpp20: fix self-assignment

Browse Source 
Going by the comment above, this needs to be endian-converted.

Found by coverity

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer
2018-09-13 11:35:27 +10:00
committed by Benjamin Tissoires
parent 7778da715e
commit 42caf3bc94
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/hidpp20.c
View File

@@ -650,8 +650,7 @@ int hidpp20_led_sw_control_get_led_state(struct hidpp20_device* device,
state = (struct hidpp20_led_sw_ctrl_led_state*) msg.msg.parameters;
// This field has to be stored in little-endian
state->mode = state->mode;
state->mode = hidpp_be_u16_to_cpu(state->mode);
if (state->mode == HIDPP20_LED_MODE_BREATHING) {
// Only parameters that is reported by these LEDs is brightness when breathing
state->breathing.brightness = hidpp_be_u16_to_cpu(state->breathing.brightness);