DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

Make sure we do not put random values in the .macro field of buttons

Browse Source 
Otherwise, as soon as we set an action for a button, we get a nice
invalid free on cleanup.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
This commit is contained in:
Benjamin Tissoires
2016-03-14 16:19:15 +01:00
parent 717505daef
commit 6190f0c7bf
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libratbag.c
View File

@@ -959,7 +959,7 @@ ratbag_button_get_button(struct ratbag_button *button)
LIBRATBAG_EXPORT enum ratbag_error_code
ratbag_button_set_button(struct ratbag_button *button, unsigned int btn)
{
struct ratbag_button_action action;
struct ratbag_button_action action = {0};
int rc;
if (!button->profile->device->driver->write_button)
@@ -989,7 +989,7 @@ LIBRATBAG_EXPORT enum ratbag_error_code
ratbag_button_set_special(struct ratbag_button *button,
enum ratbag_button_action_special act)
{
struct ratbag_button_action action;
struct ratbag_button_action action = {0};
int rc;
/* FIXME: range checks */
@@ -1027,7 +1027,7 @@ ratbag_button_set_key(struct ratbag_button *button,
unsigned int *modifiers,
size_t sz)
{
struct ratbag_button_action action;
struct ratbag_button_action action = {0};
int rc;
/* FIXME: range checks */