DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

hidpp10: make hidpp10_request_command static

Browse Source 
For commands we support we have the wrapper functions, they're safer to use.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer
2015-10-15 12:42:23 +10:00
parent 35d24890ae
commit 70db86f0c4
2 changed files with 17 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/hidpp10.c
View File

@@ -43,6 +43,22 @@
#include "libratbag-util.h"
#include "libratbag-hidraw.h"
struct _hidpp10_message {
uint8_t report_id;
uint8_t device_idx;
uint8_t sub_id;
uint8_t address;
union {
uint8_t parameters[3];
uint8_t string[16];
};
} __attribute__((packed));
union hidpp10_message {
struct _hidpp10_message msg;
uint8_t data[LONG_MESSAGE_LENGTH];
};
#define ERROR_MSG(__hidpp_msg, idx) { \
.msg = { \
.report_id = REPORT_ID_SHORT, \
@@ -86,7 +102,7 @@ const char *device_types[0xFF] = {
[0x0A ... 0xFE] = NULL,
};
int
static int
hidpp10_request_command(struct hidpp10_device *dev, union hidpp10_message *msg)
{
union hidpp10_message read_buffer;

17
src/hidpp10.h
View File

@@ -36,25 +36,8 @@
struct hidpp10_device;
struct _hidpp10_message {
uint8_t report_id;
uint8_t device_idx;
uint8_t sub_id;
uint8_t address;
union {
uint8_t parameters[3];
uint8_t string[16];
};
} __attribute__((packed));
union hidpp10_message {
struct _hidpp10_message msg;
uint8_t data[LONG_MESSAGE_LENGTH];
};
void hidpp10_device_destroy(struct hidpp10_device *dev);
int hidpp10_request_command(struct hidpp10_device *device, union hidpp10_message *msg);
struct hidpp10_device *hidpp10_device_new_from_wpid(const struct hidpp_device *base,
uint16_t wpid);
struct hidpp10_device *hidpp10_device_new_from_idx(const struct hidpp_device *base,