DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

ratbagd: standardise the log messages a bit better

Browse Source 
Prefix with the sysname of the device, then have a 'failed to ...'

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer
2017-10-11 14:39:09 +10:00
committed by Benjamin Tissoires
parent af78dc4ec2
commit a926afe8de
3 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
ratbagd/ratbagd-device.c
View File

@@ -125,7 +125,7 @@ static int ratbagd_device_get_device_name(sd_bus *bus,
name = ratbag_device_get_name(device->lib_device);
if (!name) {
log_error("Unable to fetch name for %s\n",
log_error("%s: failed to fetch name\n",
ratbagd_device_get_sysname(device));
name = "";
}
@@ -146,7 +146,7 @@ static int ratbagd_device_get_svg(sd_bus *bus,
svg = ratbag_device_get_svg_name(device->lib_device);
if (!svg) {
log_error("Unable to fetch SVG for %s\n",
log_error("%s: failed to fetch SVG\n",
ratbagd_device_get_sysname(device));
svg = "";
}
@@ -171,7 +171,7 @@ static int ratbagd_device_get_theme_svg(sd_bus_message *m,
svg = ratbag_device_get_svg_name(device->lib_device);
if (!svg) {
log_error("Unable to fetch SVG for %s, using fallback\n",
log_error("%s: failed to fetch SVG, using fallback\n",
ratbagd_device_get_sysname(device));
svg = FALLBACK_SVG_NAME;
}
@@ -335,7 +335,7 @@ int ratbagd_device_new(struct ratbagd_device **out,
i);
if (r < 0) {
errno = -r;
log_error("Cannot allocate profile for '%s': %m\n",
log_error("%s: failed to allocate profile: %m\n",
device->sysname);
}
}
@@ -460,7 +460,7 @@ void ratbagd_device_link(struct ratbagd_device *device)
}
if (r < 0) {
errno = -r;
log_error("Cannot register profile interfaces for '%s': %m\n",
log_error("%s: failed to register profile interfaces: %m\n",
device->sysname);
return;
}
@@ -470,7 +470,7 @@ void ratbagd_device_link(struct ratbagd_device *device)
device,
device->profiles[i]);
if (r < 0) {
log_error("Cannot register resolutions for '%s': %m\n",
log_error("%s: failed to register resolutions: %m\n",
device->sysname);
}
@@ -478,7 +478,7 @@ void ratbagd_device_link(struct ratbagd_device *device)
device,
device->profiles[i]);
if (r < 0) {
log_error("Cannot register buttons for '%s': %m\n",
log_error("%s: failed to register buttons: %m\n",
device->sysname);
}
@@ -486,7 +486,7 @@ void ratbagd_device_link(struct ratbagd_device *device)
device,
device->profiles[i]);
if (r < 0) {
log_error("Cannot register leds for '%s': %m\n",
log_error("%s: failed to register leds: %m\n",
device->sysname);
}
}

12
ratbagd/ratbagd-profile.c
View File

@@ -500,7 +500,7 @@ int ratbagd_profile_new(struct ratbagd_profile **out,
i);
if (r < 0) {
errno = -r;
log_error("Cannot allocate resolution for '%s': %m\n",
log_error("%s: failed to allocate resolution: %m\n",
ratbagd_device_get_sysname(device));
}
}
@@ -517,7 +517,7 @@ int ratbagd_profile_new(struct ratbagd_profile **out,
i);
if (r < 0) {
errno = -r;
log_error("Cannot allocate button for '%s': %m\n",
log_error("%s: failed to allocate button: %m\n",
ratbagd_device_get_sysname(device));
}
}
@@ -534,7 +534,7 @@ int ratbagd_profile_new(struct ratbagd_profile **out,
i);
if (r < 0) {
errno = -r;
log_error("Cannot allocate led for '%s': %m\n",
log_error("%s: failed to allocate led: %m\n",
ratbagd_device_get_sysname(device));
}
}
@@ -647,7 +647,7 @@ int ratbagd_profile_register_resolutions(struct sd_bus *bus,
}
if (r < 0) {
errno = -r;
log_error("Cannot register resolutions for '%s': %m\n",
log_error("%s: failed to register resolutions: %m\n",
ratbagd_device_get_sysname(device));
}
@@ -713,7 +713,7 @@ int ratbagd_profile_register_buttons(struct sd_bus *bus,
}
if (r < 0) {
errno = -r;
log_error("Cannot register buttons for '%s': %m\n",
log_error("%s: failed to register buttons: %m\n",
ratbagd_device_get_sysname(device));
}
@@ -779,7 +779,7 @@ int ratbagd_profile_register_leds(struct sd_bus *bus,
}
if (r < 0) {
errno = -r;
log_error("Cannot register leds for '%s': %m\n",
log_error("%s: failed to register leds: %m\n",
ratbagd_device_get_sysname(device));
}

2
ratbagd/ratbagd.c
View File

@@ -251,7 +251,7 @@ static void ratbagd_process_device(struct ratbagd *ctx,
ratbag_device_unref(lib_device);
if (r < 0) {
log_error("Cannot track device '%s'\n", name);
log_error("%s: cannot track device\n", name);
return;
}