DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

tools: fix 2 valgrind complains

Browse Source 
When accessing the buttons of a profile, we should not unref it until
we are done (or there will be some illegal access to a free-ed pointer).

The last profile_unref should be called against the active_profile, not
the last profile.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
This commit is contained in:
Benjamin Tissoires
2015-08-19 11:31:58 -04:00
parent fe839b2a90
commit abc7ac1029
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tools/ratbag-command.c
View File

@@ -221,8 +221,6 @@ ratbag_cmd_info(struct ratbag *ratbag, uint32_t flags, int argc, char **argv)
printf(" Resolution: %ddpi\n", dpi);
printf(" Report rate: %dhz\n", rate);
ratbag_profile_unref(profile);
for (b = 0; b < num_buttons; b++) {
enum ratbag_button_type type;
@@ -231,8 +229,11 @@ ratbag_cmd_info(struct ratbag *ratbag, uint32_t flags, int argc, char **argv)
printf("Button: %d type %s\n", b, button_type_to_str(type));
button = ratbag_button_unref(button);
}
profile = ratbag_profile_unref(profile);
}
profile = ratbag_profile_unref(profile);
active_profile = ratbag_profile_unref(active_profile);
device = ratbag_device_unref(device);
rc = 0;