DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

sinowealth: remove per-resolution led

Browse Source 
The glorious mice uses a single profile. To differentiate between
resolutions each one has customizable color. A led on the bottom
of the mouse shows the active resolution color.

Libratbag does not support a per-resolution color.

To allow adjusting these colors the sinowealth driver defines a led
for each resolution. This is a misuse of the model and will cause
problems when the mouse is added to Piper.

This patch removes the per-resolution leds and hardcodes the led
count to one.
This commit is contained in:
Thomas H.P. Andersen
2020-09-22 23:35:06 +02:00
committed by Filipe Laíns
parent ed2439e5e2
commit aeda65cbfa
1 changed files with 1 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/driver-sinowealth.c
View File

@@ -309,14 +309,6 @@ sinowealth_read_profile(struct ratbag_profile *profile)
}
ratbag_led_unref(led);
/* DPI indicator LED */
for (int i = 1; i < SINOWEALTH_NUM_DPIS + 1; i++) {
led = ratbag_profile_get_led(profile, i);
led->mode = RATBAG_LED_ON;
led->color = sinowealth_raw_to_color(config->dpi_color[i - 1]);
ratbag_led_unref(led);
}
profile->is_active = true;
return 0;
@@ -335,7 +327,7 @@ sinowealth_init_profile(struct ratbag_device *device)
unsigned int dpis[num_dpis];
/* TODO: Button remapping */
ratbag_device_init_profiles(device, 1, SINOWEALTH_NUM_DPIS, 0, SINOWEALTH_NUM_DPIS + 1);
ratbag_device_init_profiles(device, 1, SINOWEALTH_NUM_DPIS, 0, 1);
profile = ratbag_device_get_profile(device, 0);
@@ -360,16 +352,6 @@ sinowealth_init_profile(struct ratbag_device *device)
ratbag_led_set_mode_capability(led, RATBAG_LED_BREATHING);
ratbag_led_unref(led);
/* Set up DPI indicator LEDs */
for (int i = 1; i < SINOWEALTH_NUM_DPIS + 1; i++) {
led = ratbag_profile_get_led(profile, i);
led->type = RATBAG_LED_TYPE_DPI;
led->colordepth = RATBAG_LED_COLORDEPTH_RGB_888;
led->mode = RATBAG_LED_ON;
ratbag_led_set_mode_capability(led, RATBAG_LED_ON);
ratbag_led_unref(led);
}
ratbag_profile_unref(profile);
}
@@ -468,13 +450,6 @@ sinowealth_commit(struct ratbag_device *device)
}
ratbag_led_unref(led);
/* DPI indicator LED */
for (int i = 1; i < SINOWEALTH_NUM_DPIS + 1; i++) {
led = ratbag_profile_get_led(profile, i);
config->dpi_color[i - 1] = sinowealth_color_to_raw(led->color);
ratbag_led_unref(led);
}
config->config_write = 0x7b; /* magic */
rc = ratbag_hidraw_set_feature_report(device, SINOWEALTH_REPORT_ID_CONFIG,