DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

tools: check snprintf size argument to prevent potential overflow

Browse Source
This commit is contained in:
Yaroslav Chvanov
2023-02-25 00:05:58 +03:00
parent e9e9d8e3fe
commit b275204c87
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/shared.c
View File

@@ -247,6 +247,10 @@ button_action_macro_to_str(struct ratbag_button *button)
offset = snprintf(str, sizeof(str), "macro \"%s\":",
name ? name : "UNKNOWN");
for (i = 0; i < MAX_MACRO_EVENTS; i++) {
if (offset < 0 || offset >= (int)sizeof(str) - offset) {
break;
}
enum ratbag_macro_event_type type = ratbag_button_macro_get_event_type(macro, i);
int key = ratbag_button_macro_get_event_key(macro, i);
int timeout = ratbag_button_macro_get_event_timeout(macro, i);