DrathOrg/libratbag-plus
1
0
Fork 0
forked from drath/libratbag
Code Pull Requests Activity

tools: ratbagctl: fixes for parsing arguments

Browse Source 
We shouldn't try to access input_string[0] if len(input_string) is null.
Meaning a condition in the break in the while loop could be checked
earlier (or later).

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
This commit is contained in:
Benjamin Tissoires
2017-08-22 16:02:53 +02:00
committed by Peter Hutterer
parent aa251448d3
commit c1c8b1eda2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/ratbagctl.in
View File

@@ -1144,7 +1144,7 @@ class RatbagParserSwitch(RatbagParser):
parser.set_defaults(subparse=self.sub_parse)
def _sub_parse(self, input_string, ns):
if len(input_string) >= 0 and self.N_access is not None:
if len(input_string) > 0 and self.N_access is not None:
# retrieve first numbered element if any
try:
int(input_string[0])
@@ -1301,10 +1301,10 @@ class RatbagParserRoot(object):
ns.subparse = None
while subparser:
while rest and subparser:
old_rest = rest
ns, rest = subparser.parse_known_args(rest, namespace=ns)
if not rest or old_rest == rest:
if old_rest == rest:
break
pr_debug(ns, ns, rest)
if ns.subparse: