drath/libratbag
1
0
Fork 1
mirror of https://github.com/libratbag/libratbag.git synced 2026-11-07 23:23:52 +01:00
Code Issues Projects Releases Wiki Activity

sinowealth: sanity check output of all raw data getters

Browse Source 
Well, of almost all, config getter's output is not checked as it may
have seemingly incorrect data in some cases.

Potentially some mice may not support some commands but look like they
do. You can see this guard in action if you run
`sinowealth_print_long_lod_and_anglesnapping` after any other command
that sets 6 byte long buffer on non-long mice.
This commit is contained in:
Yaroslav Chvanov
2022-01-29 19:55:22 +03:00
committed by Peter Hutterer
parent 3793e32ebd
commit 132fc21212
1 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/driver-sinowealth.c
View File

@@ -431,6 +431,12 @@ sinowealth_get_active_profile(struct ratbag_device *device)
return -1;
}
/* Check if we got a response for correct command. */
if (buf[1] != SINOWEALTH_CMD_PROFILE) {
log_error(device->ratbag, "Couldn't read profile index, got result of command %#x instead\n", buf[1]);
return -1;
}
unsigned int index = buf[2] - 1;
drv_data->current_profile_index = index;
@@ -484,6 +490,12 @@ sinowealth_get_fw_version(struct ratbag_device *device, char buf[4])
return -1;
}
/* Check if we got a response for correct command. */
if (version[1] != SINOWEALTH_CMD_FIRMWARE_VERSION) {
log_error(device->ratbag, "Couldn't read firmware version, got result of command %#x instead\n", version[1]);
return -1;
}
memcpy(buf, version + 2, 4);
return 0;
@@ -510,6 +522,12 @@ sinowealth_get_debounce_time(struct ratbag_device *device)
return -1;
}
/* Check if we got a response for correct command. */
if (buf[1] != SINOWEALTH_CMD_DEBOUNCE) {
log_error(device->ratbag, "Couldn't read debounce time, got result of command %#x instead\n", buf[1]);
return -1;
}
return buf[2] * 2;
}
@@ -538,6 +556,13 @@ sinowealth_print_long_lod_and_anglesnapping(struct ratbag_device *device)
log_error(device->ratbag, "Couldn't read LOD and angle snapping: %d\n", rc);
return -1;
}
/* Check if we got a response for correct command. */
if (buf[1] != SINOWEALTH_CMD_LONG_ANGLESNAPPING_AND_LOD) {
log_error(device->ratbag, "Couldn't read LOD and angle snapping, got result of command %#x instead\n", buf[1]);
return -1;
}
log_info(device->ratbag, "LOD is high: %u\n", buf[2] - 1);
log_info(device->ratbag, "Angle snapping enabled: %u\n", buf[3]);