drath/libratbag
1
0
Fork 1
mirror of https://github.com/libratbag/libratbag.git synced 2026-11-07 23:23:52 +01:00
Code Issues Projects Releases Wiki Activity

RatbagdLed: clamp values instead of returning an error

Browse Source 
We cannot return error codes, but requesting a resync is overkill.
Instead, let's be nice and clamp these values.
This commit is contained in:
Jente Hidskes
2017-09-11 20:19:35 +02:00
committed by Peter Hutterer
parent 26a6215122
commit 26e7237010
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
ratbagd/ratbagd-led.c
View File

@@ -131,8 +131,12 @@ static int ratbagd_led_set_color(sd_bus *bus,
if (r < 0)
return r;
if (c.red > 255 || c.green > 255 || c.blue > 255)
return RATBAG_ERROR_VALUE;
if (c.red > 255)
c.red = 255;
if (c.green > 255)
c.green = 255;
if (c.blue > 255)
c.blue = 255;
r = ratbag_led_set_color(led->lib_led, c);
@@ -179,8 +183,10 @@ static int ratbagd_led_set_effect_rate(sd_bus *bus,
if (r < 0)
return r;
if (rate < 100 || rate > 20000)
return 0;
if (rate < 100)
rate = 100;
else if (rate > 20000)
rate = 20000;
r = ratbag_led_set_effect_rate(led->lib_led, rate);
@@ -228,7 +234,7 @@ static int ratbagd_led_set_brightness(sd_bus *bus,
return r;
if (brightness > 255)
return 0;
brightness = 255;
r = ratbag_led_set_brightness(led->lib_led, brightness);