drath/libratbag
1
0
Fork 1
mirror of https://github.com/libratbag/libratbag.git synced 2026-11-07 23:23:52 +01:00
Code Issues Projects Releases Wiki Activity

hidpp: Fix error string array size

Browse Source 
Extend error strings array so reading 0xFF as an error code would not overflow.
This commit is contained in:
Clément Vuchener
2017-08-17 11:01:18 +02:00
committed by Peter Hutterer
parent 468787601e
commit 49b7029506
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/hidpp-generic.c
View File

@@ -36,7 +36,7 @@
#include "libratbag-private.h"
const char *hidpp10_errors[0xFF] = {
const char *hidpp10_errors[0x100] = {
[0x00] = "ERR_SUCCESS",
[0x01] = "ERR_INVALID_SUBID",
[0x02] = "ERR_INVALID_ADDRESS",
@@ -50,10 +50,10 @@ const char *hidpp10_errors[0xFF] = {
[0x0A] = "ERR_REQUEST_UNAVAILABLE",
[0x0B] = "ERR_INVALID_PARAM_VALUE",
[0x0C] = "ERR_WRONG_PIN_CODE",
[0x0D ... 0xFE] = NULL,
[0x0D ... 0xFF] = NULL,
};
const char *hidpp20_errors[0xFF] = {
const char *hidpp20_errors[0x100] = {
[0x00] = "ERR_NO_ERROR",
[0x01] = "ERR_UNKNOWN",
[0x02] = "ERR_INVALID_ARGUMENT",
@@ -64,7 +64,7 @@ const char *hidpp20_errors[0xFF] = {
[0x07] = "ERR_INVALID_FUNCTION_ID",
[0x08] = "ERR_BUSY",
[0x09] = "ERR_UNSUPPORTED",
[0x0A ... 0xFE] = NULL,
[0x0A ... 0xFF] = NULL,
};
struct hidpp20_1b04_action_mapping {

4
src/hidpp-generic.h
View File

@@ -108,8 +108,8 @@ hidpp_device_set_log_handler(struct hidpp_device *dev,
enum hidpp_log_priority priority,
void *userdata);
extern const char *hidpp10_errors[0xFF];
extern const char *hidpp20_errors[0xFF];
extern const char *hidpp10_errors[0x100];
extern const char *hidpp20_errors[0x100];
const char *
hidpp20_1b04_get_physical_mapping_name(uint16_t value);