drath/libratbag
1
0
Fork 1
mirror of https://github.com/libratbag/libratbag.git synced 2026-11-07 23:23:52 +01:00
Code Issues Projects Releases Wiki Activity

Mark log_msg and log_msg_va with attribute(printf)

Browse Source 
And fix the warnings resulting from that.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer
2015-10-14 10:03:08 +10:00
parent 1b20beaada
commit bf4e288dfe
3 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/hidpp10.c
View File

@@ -630,31 +630,31 @@ hidpp10_get_profile(struct hidpp10_device *dev, int8_t number, struct hidpp10_pr
switch (button->any.type) {
case PROFILE_BUTTON_TYPE_BUTTON:
log_raw(ratbag,
"Button %d: button %d\n",
"Button %zd: button %d\n",
i,
ffs(hidpp10_get_unaligned_u16le(&button->button.button_flags_lsb)));
break;
case PROFILE_BUTTON_TYPE_KEYS:
log_raw(ratbag,
"Button %d: key %d modifier %x\n",
"Button %zd: key %d modifier %x\n",
i,
button->keyboard_keys.key,
button->keyboard_keys.modifier_flags);
break;
case PROFILE_BUTTON_TYPE_SPECIAL:
log_raw(ratbag,
"Button %d: special %x\n",
"Button %zd: special %x\n",
i,
ffs(hidpp10_get_unaligned_u16le(&button->special.flags1)));
break;
case PROFILE_BUTTON_TYPE_CONSUMER_CONTROL:
log_raw(ratbag,
"Button %d: consumer: %x\n",
"Button %zd: consumer: %x\n",
i,
hidpp10_get_unaligned_u16(&button->consumer_control.consumer_control1));
break;
case PROFILE_BUTTON_TYPE_DISABLED:
log_raw(ratbag, "Button %d: disabled\n", i);
log_raw(ratbag, "Button %zd: disabled\n", i);
break;
default:
/* FIXME: this is the page number for the macro,

6
src/libratbag-private.h
View File

@@ -399,10 +399,12 @@ void
log_msg_va(struct ratbag *ratbag,
enum ratbag_log_priority priority,
const char *format,
va_list args);
va_list args)
LIBRATBAG_ATTRIBUTE_PRINTF(3, 0);
void log_msg(struct ratbag *ratbag,
enum ratbag_log_priority priority,
const char *format, ...);
const char *format, ...)
LIBRATBAG_ATTRIBUTE_PRINTF(3, 4);
void
log_buffer(struct ratbag *ratbag,
enum ratbag_log_priority priority,

2
src/libratbag.c
View File

@@ -458,7 +458,7 @@ ratbag_register_driver(struct ratbag *ratbag, struct ratbag_driver *driver)
}
if (!driver->probe || !driver->remove) {
log_bug_libratbag(ratbag, "Driver %s is incomplete.\n");
log_bug_libratbag(ratbag, "Driver %s is incomplete.\n", driver->name);
return;
}
list_insert(&ratbag->drivers, &driver->link);