drath/libratbag
1
0
Fork 1
mirror of https://github.com/libratbag/libratbag.git synced 2026-11-07 23:23:52 +01:00
Code Issues Projects Releases Wiki Activity

hidpp10: return EINVAL instead of aborting

Browse Source 
While these indicate an obvious error in the caller's code, there is no
need to crash the whole program because of this.
This commit is contained in:
Yaroslav Chvanov
2023-01-27 13:42:32 +03:00
parent 6dcd17d340
commit fbdb41b073
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/hidpp10.c
View File

@@ -180,7 +180,8 @@ hidpp10_request_command(struct hidpp10_device *dev, union hidpp10_message *msg)
command_size = LONG_MESSAGE_LENGTH;
break;
default:
abort();
hidpp_log_error(&dev->base, "Incorrect message report id: %02x\n", msg->msg.report_id);
return -EINVAL;
}
/* create the expected header */
@@ -1943,7 +1944,8 @@ hidpp10_set_led_status(struct hidpp10_device *dev,
case HIDPP10_LED_STATUS_SLOW_OFF:
break;
default:
abort();
hidpp_log_error(&dev->base, "Incorrect LED status: %02x\n", led[i]);
return -EINVAL;
}
}